The Mana World

Feel the mana power growing inside you!
It is currently Tue Jun 18, 2013 6:25 am

All times are UTC - 1 hour




Post new topic Reply to topic  [ 31 posts ]  Go to page Previous  1, 2, 3  Next
Author Message
 Post subject: Re: Sema script changes proposal
PostPosted: Wed Nov 30, 2011 7:29 am 
Offline
Forum Administrator
Forum Administrator
User avatar

Joined: Thu Aug 25, 2005 3:08 pm
Posts: 7820
Location: Germany
Qwerty Dragon wrote:
Isn't this game at its root Linux, not Windows?

It's multi-plattform.

Just because you penguin petters are in the majority here (for a change ;)) doesn't mean you have to discriminate us windows users :P

_________________
  • former Manasource Programmer
  • former TMW Pixel artist
  • NOT a game master
Please do not send me any inquiries regarding player accounts on TMW.


Top
 Profile  
 
 Post subject: Re: Sema script changes proposal
PostPosted: Wed Nov 30, 2011 10:51 am 
Offline
TMW Committee Member
TMW Committee Member
User avatar

Joined: Wed Sep 22, 2010 6:28 pm
Posts: 701
Qwerty Dragon, I just tried to apply your patch and I get the error message
Quote:
Applying: Some changes to what NPC Sema says to players.
error: patch failed: world/map/npc/002-4/miners.txt:7
error: world/map/npc/002-4/miners.txt: patch does not apply
Patch failed at 0001 Some changes to what NPC Sema says to players.

I also noticed that there are still tabs in the file, but we've replaced them with four spaces some time ago.
Can you please tell which repository you cloned and if it is up-to-date?

You can find some informations about the repositories we use in this sticky:
http://forums.themanaworld.org/viewtopic.php?f=13&t=12981

_________________
Content Leader of tmwAthena
Interested in development? Have a look here:
Repositories: server-data client-data - Content Board - How to set up a server - irc.freenode.org #themanaworld-dev
Official testserver: caliban.homeip.net:6901


Top
 Profile  
 
 Post subject: Re: Sema script changes proposal
PostPosted: Wed Nov 30, 2011 4:50 pm 
Offline
User avatar

Joined: Sun Feb 20, 2011 8:09 pm
Posts: 1354
Location: ^ ^
Crush wrote:
Just because you penguin petters are in the majority here (for a change ;)) doesn't mean you have to discriminate us windows users :P


Yes, it does, because Windows sucks as a development environment. (so does Mac, but for a different reason)

_________________
Source Lead for tmwa: chat.freenode.net #tmwa
<BigCrunch>look at o11c, half the time he speaks in code, yet he's getting **** done
<Freeyorp> Jaxad0127 is pretty awesome, despite the Java :>
<veryape> tmw and evol is like linux vs bsd
<veryape> evol might be more coherent but have less stuff, tmw is a great chaos that somehow works together imo


Top
 Profile  
 
 Post subject: Re: Sema script changes proposal
PostPosted: Wed Nov 30, 2011 4:53 pm 
Offline
Forum Administrator
Forum Administrator
User avatar

Joined: Thu Aug 25, 2005 3:08 pm
Posts: 7820
Location: Germany
o11c wrote:
Yes, it does, because Windows sucks as a development environment. (so does Mac, but for a different reason)
Good one, you almost tricked me into a pointless operating system flamewar.

_________________
  • former Manasource Programmer
  • former TMW Pixel artist
  • NOT a game master
Please do not send me any inquiries regarding player accounts on TMW.


Top
 Profile  
 
 Post subject: Re: Sema script changes proposal
PostPosted: Wed Nov 30, 2011 5:09 pm 
Offline
Novice
Novice
User avatar

Joined: Tue Mar 08, 2011 6:41 pm
Posts: 160
Location: Frost's Bedroom Wardrobe
SuperTux rules.

_________________
It's hard to beat someone who never gives up.
The quickest way to fail, is to never try.
GREEN. Dark of course.


Top
 Profile  
 
 Post subject: .
PostPosted: Wed Nov 30, 2011 6:12 pm 
Offline
Novice
Novice

Joined: Mon Jun 06, 2011 4:53 pm
Posts: 128
.

_________________
http://forums.themanaworld.net/viewtopi ... 88#p131988


Last edited by Qwerty Dragon on Sun Apr 21, 2013 11:20 pm, edited 2 times in total.

Top
 Profile  
 
 Post subject: Re: Sema script changes proposal
PostPosted: Thu Dec 01, 2011 12:45 am 
Offline
User avatar

Joined: Sun Feb 20, 2011 8:09 pm
Posts: 1354
Location: ^ ^
Changing any command in the instructions means you are not following the instructions.

You probably had to make that change due to having an old version of git. For Ubuntu, you can upgrade to the latest release or use the PPA: https://launchpad.net/~git-core/+archive/ppa

Any up-to-date Linux distribution is suitable for development.

Also, before preparing any patches, you must do: git pull. Note that occasionally you need to pull from the tmw-eathena repository as well as tmwa-server-test

_________________
Source Lead for tmwa: chat.freenode.net #tmwa
<BigCrunch>look at o11c, half the time he speaks in code, yet he's getting **** done
<Freeyorp> Jaxad0127 is pretty awesome, despite the Java :>
<veryape> tmw and evol is like linux vs bsd
<veryape> evol might be more coherent but have less stuff, tmw is a great chaos that somehow works together imo


Top
 Profile  
 
 Post subject: .
PostPosted: Thu Dec 01, 2011 8:06 am 
Offline
Novice
Novice

Joined: Mon Jun 06, 2011 4:53 pm
Posts: 128
.

_________________
http://forums.themanaworld.net/viewtopi ... 88#p131988


Last edited by Qwerty Dragon on Sun Apr 21, 2013 11:20 pm, edited 2 times in total.

Top
 Profile  
 
 Post subject: Re: Sema script changes proposal
PostPosted: Thu Dec 01, 2011 3:03 pm 
Offline
TMW Committee Member
TMW Committee Member
User avatar

Joined: Wed Sep 22, 2010 6:28 pm
Posts: 701
Qwerty Dragon wrote:
I did new install successfully using information above. New attempt at patch is in attachment.
This patch works to apply. :)
The dialogue changes are nice, but there is some inconsistency regarding using one space on the end of a sentence or two spaces. The original version uses two spaces but some of your changes use only one.
We had a brief discussion about that in IRC and came to the conclusion that this is a matter of taste, but should be consistent within a single script. Please fix that then I can push your patch.

_________________
Content Leader of tmwAthena
Interested in development? Have a look here:
Repositories: server-data client-data - Content Board - How to set up a server - irc.freenode.org #themanaworld-dev
Official testserver: caliban.homeip.net:6901


Top
 Profile  
 
 Post subject: .
PostPosted: Thu Dec 01, 2011 8:47 pm 
Offline
Novice
Novice

Joined: Mon Jun 06, 2011 4:53 pm
Posts: 128
.

_________________
http://forums.themanaworld.net/viewtopi ... 88#p131988


Last edited by Qwerty Dragon on Sun Apr 21, 2013 11:20 pm, edited 2 times in total.

Top
 Profile  
 
 Post subject: .
PostPosted: Thu Dec 01, 2011 8:58 pm 
Offline
Novice
Novice

Joined: Mon Jun 06, 2011 4:53 pm
Posts: 128
.

_________________
http://forums.themanaworld.net/viewtopi ... 88#p131988


Last edited by Qwerty Dragon on Sun Apr 21, 2013 11:21 pm, edited 2 times in total.

Top
 Profile  
 
 Post subject: Re: Sema script changes proposal
PostPosted: Thu Dec 01, 2011 9:48 pm 
Offline
User avatar

Joined: Sun Feb 20, 2011 8:09 pm
Posts: 1354
Location: ^ ^
That takes care of pulling client data to keep it in sync with server-data.

But, for various reasons, the server sources are not automatically synchronized.

_________________
Source Lead for tmwa: chat.freenode.net #tmwa
<BigCrunch>look at o11c, half the time he speaks in code, yet he's getting **** done
<Freeyorp> Jaxad0127 is pretty awesome, despite the Java :>
<veryape> tmw and evol is like linux vs bsd
<veryape> evol might be more coherent but have less stuff, tmw is a great chaos that somehow works together imo


Top
 Profile  
 
 Post subject: Re: Sema script changes proposal
PostPosted: Thu Dec 01, 2011 9:50 pm 
Offline
Knight
Knight
User avatar

Joined: Sat Jan 09, 2010 6:22 pm
Posts: 1252
Please note that a commit about Sema's script got pushed recently. It adds the new sprite you (Qwerty Dragon) made. If you want your patch to apply correctly, you must do "git pull" first. In fact, it just changes the ID of the NPC to 340.

Regards.

_________________
Let's agree to disagree.


Top
 Profile  
 
 Post subject: Re: Sema script changes proposal
PostPosted: Fri Dec 02, 2011 6:27 am 
Offline
TMW Committee Member
TMW Committee Member
User avatar

Joined: Wed Sep 22, 2010 6:28 pm
Posts: 701
Ali-G wrote:
Please note that a commit about Sema's script got pushed recently. It adds the new sprite you (Qwerty Dragon) made. If you want your patch to apply correctly, you must do "git pull" first. In fact, it just changes the ID of the NPC to 340.
Since the dialog changes are on different lines in the file than the change of the ID, there is no problem with this. Though you're right that patches should in general always be based on the latest version of the testing repository.

Qwerty Dragon wrote:
Made changes.
I pushed your patch. :)

_________________
Content Leader of tmwAthena
Interested in development? Have a look here:
Repositories: server-data client-data - Content Board - How to set up a server - irc.freenode.org #themanaworld-dev
Official testserver: caliban.homeip.net:6901


Top
 Profile  
 
 Post subject: .
PostPosted: Sat Dec 03, 2011 2:33 am 
Offline
Novice
Novice

Joined: Mon Jun 06, 2011 4:53 pm
Posts: 128
.

_________________
http://forums.themanaworld.net/viewtopi ... 88#p131988


Last edited by Qwerty Dragon on Sun Apr 21, 2013 11:22 pm, edited 2 times in total.

Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 31 posts ]  Go to page Previous  1, 2, 3  Next

All times are UTC - 1 hour


Who is online

Users browsing this forum: Google [Bot] and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group