some code to test

Content and general development discussion, including quest scripts and server code.
Post Reply
User avatar
o11c
Grand Knight
Grand Knight
Posts: 2262
Joined: 20 Feb 2011, 22:09
Location: ^ ^

some code to test

Post by o11c »

I really hate to do this, but I have practically no time at all.

I have some code on o11c/test that redoes the file IO subsystem. It needs verification that reading and writing all files is correct, from all paths.

This is a list of call sites that need to be checked. Additionally, they should be checked for both the case where the file exists and the case where it does not exist.
  • login server
    • append ladmin log
    • read ladmin stdin
    • read ladmin cfg
  • eathena monitor
    • read monitor cfg (not used)
  • char server
    • read party
    • lock party
    • append char log
    • read char
    • lock char
    • write online txt (dangerous, but subject to permission problems otherwise, will be fixed properly later - this is not a new bug)
    • write online html (likewise)
    • read char lancfg
    • read char cfg
    • read storage
    • lock storage
    • read accreg
    • lock accreg
    • read inter cfg
  • login server
    • append login log
    • read gm
    • read account
    • lock account
    • append gm
    • append login unknown packets
    • lock gm
    • read gm
    • append login unknown packets
    • append login unknown packets
    • read login lancfg
    • read login cfg
  • map server
    • read npc source
    • read resnametable
    • append packet_txt
    • read mob db
    • read mob skill db
    • read battle cfg
    • write atcommand conf
    • append gm log
    • read const
    • read mapreg
    • lock mapreg
    • read skill
    • read item
    • read motd
    • append map log
    • read map cfg
Former programmer for the TMWA server.
User avatar
wushin
TMW Adviser
TMW Adviser
Posts: 1759
Joined: 18 Dec 2012, 06:56
Location: RiverBest, Brew City, Merica
Contact:

Re: some code to test

Post by wushin »

open("npc/functions/barber.txt", O_RDONLY|O_CLOEXEC) = 4
read(4, "// The Barber script has been ar"..., 4096) = 3417
and sits there forever.
The secret to getting all the important stuff done is doing nothing.
User avatar
o11c
Grand Knight
Grand Knight
Posts: 2262
Joined: 20 Feb 2011, 22:09
Location: ^ ^

Re: some code to test

Post by o11c »

Don't you hate it when pushing one segment of code makes something else break?

Workaround pushed ... not sure if I'll investigate the real problem or leave it until my general rewrite of that area.
Former programmer for the TMWA server.
User avatar
wushin
TMW Adviser
TMW Adviser
Posts: 1759
Joined: 18 Dec 2012, 06:56
Location: RiverBest, Brew City, Merica
Contact:

Re: some code to test

Post by wushin »

Appears to work fine for me.
The secret to getting all the important stuff done is doing nothing.
Post Reply