want a makefile for the tmw-branding package

[o11c]

In order to make life easier for packagers, the 'tmw-branding' package should have a makefile, with appropriate variables allowing editing the currently hard-coded paths.

I could do this, but as it's completely isolated from everything else, so it would be a good, simple, task for someone else to do.

For the bug request, see https://github.com/themanaworld/tmw-branding/issues/2

For the kind of things it needs to do, see http://sources.gentoo.org/cgi-bin/viewv ... iew=markup

[Ablu]

Probably a bit easier to understand for human beings:

Code: Select all

install -D -p -m 755 %{name} %{buildroot}%{_bindir}/%{name}
install -D -p -m 644 data/icons/%{name}.png %{buildroot}%{_datadir}/pixmaps/%{name}.png
install -D -p -m 644 %{name}.mana %{buildroot}%{_datadir}/%{name}/%{name}.mana
mv data/ %{buildroot}%{_datadir}/%{name}/
desktop-file-install --dir=%{buildroot}%{_datadir}/applications %{name}.desktop

desktop-file is basically just an install + validation

However i do not get why this needs a Makefile.
Just do a script that runs those install commands + adds a prefix variable.

Regards
Ablu

[o11c]

The primary problem is that the path to tmw.mana must be hard coded in the script and menu entry, and the paths are different on different distributions.

Also, it's usually only one like of code to package something that is just "make; make install", instead of several.

[4144]

I pushed make file for tmw branding in manaplus repo.
Also updated some help files

[o11c]

I pushed make file for tmw branding in manaplus repo.

1. it doesn't work; it leaves ${prefix} in tmw.desktop, automake doesn't like being abused like this.
2. I need a solution in the tmw-branding repository, not in manaplus

[4144]

I pushed make file for tmw branding in manaplus repo.

1. it doesn't work; it leaves ${prefix} in tmw.desktop, automake doesn't like being abused like this.
2. I need a solution in the tmw-branding repository, not in manaplus

1. if ${prefix} was in path it left it here, if in path was no variables, it will be without variables.
I think ./configure --datadir=/real/path/here will fix ${prefix} issue.

2. In repository some files have mana as binary, wrong servers list, and it overriding some files in help directory with wrong versions.