Page 1 of 1

commandhandler

Posted: 07 Jun 2008, 22:49
by Rodge
Hey, I can't post on the mailing lists for some reason, so i just put what i was going to say on the wiki http://wiki.themanaworld.org/index.php/ ... andhandler. Those're the diffs of what i've been working on so far, i'd just like some critique before I commit them.

Re: commandhandler

Posted: 08 Jun 2008, 08:34
by trapdoor
Was there any specific reason for breaking the guild system?

I know removing its ability to see what guild members are online doesnt make the client crash, but it was a very useful feature.

--
trapdoor

Re: commandhandler

Posted: 08 Jun 2008, 13:17
by Rodge
You were using CPMSG_LIST_CHANNELUSERS_RESPONSE to see if people're online in a guild, and not for actually listing players in any channel for the user. I thought it would be better to keep the channel specific messages dealing with channel stuff, and then have a guild specific packet for that, or change other existing ones like CPMSG_GUILD_GET_MEMBERS_RESPONSE and CPMSG_GUILD_UPDATE_LIST to also say if a player is online.

I see what you were going for now though (if someone is online in the guild channel, they must be online), and i could just add that back, and use channel events to keep track of when users go on and offline? The reason I didn't think it was that important for now was because since we moved to guichan's tabs, the guild member list has been completely broken, it doesn't display anything. So in fact, users dont have the ability to see what guild members are online, heh (well, they can /listusers after this is commited anyway). Sorry I didn't make a bug about it though.

Re: commandhandler

Posted: 08 Jun 2008, 15:49
by Crush
Rodge wrote:Hey, I can't post on the mailing lists for some reason
Note that the mailing list rejects messages from addresses which haven't subscribed to it to avoid spam mails.

Re: commandhandler

Posted: 09 Jun 2008, 03:06
by Rodge
Crush wrote:
Rodge wrote:Hey, I can't post on the mailing lists for some reason
Note that the mailing list rejects messages from addresses which haven't subscribed to it to avoid spam mails.
I know, but I am registered, and I've posted before (and you replied to one of those, remember?). I've no idea what's going on with that, but its not exactly a heavy traffic list anyways, so might as well use the forum, heheh.

Re: commandhandler

Posted: 09 Jun 2008, 10:22
by trapdoor
Rodge wrote:You were using CPMSG_LIST_CHANNELUSERS_RESPONSE to see if people're online in a guild, and not for actually listing players in any channel for the user. I thought it would be better to keep the channel specific messages dealing with channel stuff, and then have a guild specific packet for that, or change other existing ones like CPMSG_GUILD_GET_MEMBERS_RESPONSE and CPMSG_GUILD_UPDATE_LIST to also say if a player is online.

I see what you were going for now though (if someone is online in the guild channel, they must be online), and i could just add that back, and use channel events to keep track of when users go on and offline? The reason I didn't think it was that important for now was because since we moved to guichan's tabs, the guild member list has been completely broken, it doesn't display anything. So in fact, users dont have the ability to see what guild members are online, heh (well, they can /listusers after this is commited anyway). Sorry I didn't make a bug about it though.
I was thinking about it after, and it probably easier just to add a bool to CPMSG_GUILD_GET_MEMBERS_RESPONSE rather than use the CPMSG_LIST_CHANNELUSERS_RESPONSE.

I was unaware the guild member list was broken, I will look into fixing it (and will use a guild msg to check for online users).

--
trapdoor