Page 1 of 1

Easter Eggs Hunt quest - not working

Posted: 12 Apr 2017, 18:00
by Rill
Will the Easter Eggs Hunt quest be repaired? (Now no eggs appear. When they did, sometimes clicking on them caused the server to crash.)

Re: Easter Eggs Hunt quest - not working

Posted: 12 Apr 2017, 18:02
by gumi
it will be repaired whenever someone fixes it, if they ever do

Re: Easter Eggs Hunt quest - not working

Posted: 12 Apr 2017, 20:05
by prsm
Rill wrote:Will the Easter Eggs Hunt quest be repaired? (Now no eggs appear. When they did, sometimes clicking on them caused the server to crash.)
Hi Rill

it is my understanding that all developers will no longer fix/tweek/or work on the legacy server.
100% of the efforts will be the new server.

So i guess that means, No it wont be fixed.

Prsm

Re: Easter Eggs Hunt quest - not working

Posted: 12 Apr 2017, 22:53
by Reid
prsm wrote:
Rill wrote:Will the Easter Eggs Hunt quest be repaired? (Now no eggs appear. When they did, sometimes clicking on them caused the server to crash.)
Hi Rill

it is my understanding that all developers will no longer fix/tweek/or work on the legacy server.
100% of the efforts will be the new server.

So i guess that means, No it wont be fixed.

Prsm
Anyone is free to fix that issue, I personally don't even have time to work on anything these last days so I won't be of any help if you need a hot fix, but I could look at what went wrong whenever I have free time.

Re: Easter Eggs Hunt quest - not working

Posted: 12 Apr 2017, 22:55
by gumi
I know exactly where the problem lies, but fixing it would imply modifying a bunch of things and of course I'm too lazy

Re: Easter Eggs Hunt quest - not working

Posted: 12 Apr 2017, 23:32
by Pawneeboy
Topic...Gumi-ed >.> :alt-7:

Re: Easter Eggs Hunt quest - not working

Posted: 13 Apr 2017, 00:12
by Reid
gumi wrote:I know exactly where the problem lies, but fixing it would imply modifying a bunch of things and of course I'm too lazy
Sum it up so that it could help someone that would like to contribute. :)

Re: Easter Eggs Hunt quest - not working

Posted: 13 Apr 2017, 01:52
by gumi
problem: too many npcs, makes the server crash
https://github.com/themanaworld/tmwa/bl ... .cpp#L1015

caused by: the puppet() script command
https://github.com/themanaworld/tmwa/bl ... .cpp#L1199

solution:
make destroy() reduce the npc counter

patch attempt:
https://github.com/themanaworld/tmwa/co ... 3a26aae123

problem: npcs are overwritten
makes everything go wrong and moving anywhere in pretty much any map teleports you to another map

revert:
https://github.com/themanaworld/tmwa/co ... 2cdc67566f

the true solution would be to make destroy() not do a npc_num-- but rather to iterate through all npcs and remove the npc from the array, then shift the array left

Re: Easter Eggs Hunt quest - not working

Posted: 13 Apr 2017, 22:50
by Reid
Ok the issue is then not just from scripting, I won't attempt to fix the server as I don't have the time nor the will to do so.
As the easter event is not working we can do GM events to compensate it on the meanwhile.

What do you think?

Re: Easter Eggs Hunt quest - not working

Posted: 14 Apr 2017, 14:27
by WildX
I will try to organise something fun this weekend. My powers are limited to spawns, pvp and the usual.

Take a moment to look into the new server and you won't be as sad about the broken easter quest. The devs are still working on really cool stuff.

Re: Easter Eggs Hunt quest - not working

Posted: 14 Apr 2017, 19:14
by gumi
WildX wrote:The devs are still working on really cool stuff.
Wait... are we?

Re: Easter Eggs Hunt quest - not working

Posted: 19 Apr 2017, 20:12
by WildX
gumi wrote:
WildX wrote:The devs are still working on really cool stuff.
Wait... are we?
Reid is building the world's tallest waffle tower and I hear that wushin makes pretty decent homemade bread.