[Manaplus] in-band packet parser misreports player gender.

Ask for help regarding any technical issue or report any bug or OS independent issues.
Post Reply
User avatar
t3st3r
Novice
Novice
Posts: 341
Joined: 11 Jun 2009, 13:46

[Manaplus] in-band packet parser misreports player gender.

Post by t3st3r » 04 Dec 2018, 02:41

I can see now TMWA+Manaplus got in-band online list based on server packets instead of http downloads, it even got detection fixed, so it works now. It seems I tested feature after building git version (b02e3369653bddc4f4af677de16dac131945e7b7).

Unfortunately parsing gender of players seems to be broken for TMWA - so as of now online list on TMW Legacy displays wrong genders. In-game display in viewport is correct (and contradicts to online list). Some "female" players are displayed as "male" in online list. Some "unspecified" were reported as "female". And so on.

Looking on code of related changes I guess it may (or may not) be good idea to treat everything client fails to understand as "unspecified" rather than something else. It looks far safer de-fault option to me, unless there is something I don't know about :D
4144
Client Developer
Client Developer
Posts: 943
Joined: 03 Aug 2009, 12:57

Re: [Manaplus] in-band packet parser misreports player gender.

Post by 4144 » 04 Dec 2018, 03:27

ah, probably tmwa gender was not converter to manaplus enum
User avatar
gumi
Developer
Developer
Posts: 705
Joined: 19 May 2014, 19:18

Re: [Manaplus] in-band packet parser misreports player gender.

Post by gumi » 04 Dec 2018, 03:45

thanks for the report :)
User avatar
TheManaWorld
Peon
Peon
Posts: 47
Joined: 17 Nov 2018, 13:13

Re: [Manaplus] in-band packet parser misreports player gender.

Post by TheManaWorld » 17 Dec 2018, 17:44

Can someone fix Manamarket please?
let me be your ⛈️
Post Reply