[Manaplus] in-band packet parser misreports player gender.
Posted: 04 Dec 2018, 01:41
I can see now TMWA+Manaplus got in-band online list based on server packets instead of http downloads, it even got detection fixed, so it works now. It seems I tested feature after building git version (b02e3369653bddc4f4af677de16dac131945e7b7).
Unfortunately parsing gender of players seems to be broken for TMWA - so as of now online list on TMW Legacy displays wrong genders. In-game display in viewport is correct (and contradicts to online list). Some "female" players are displayed as "male" in online list. Some "unspecified" were reported as "female". And so on.
Looking on code of related changes I guess it may (or may not) be good idea to treat everything client fails to understand as "unspecified" rather than something else. It looks far safer de-fault option to me, unless there is something I don't know about
Unfortunately parsing gender of players seems to be broken for TMWA - so as of now online list on TMW Legacy displays wrong genders. In-game display in viewport is correct (and contradicts to online list). Some "female" players are displayed as "male" in online list. Some "unspecified" were reported as "female". And so on.
Looking on code of related changes I guess it may (or may not) be good idea to treat everything client fails to understand as "unspecified" rather than something else. It looks far safer de-fault option to me, unless there is something I don't know about
