Selim The Dyer

Got something on your mind about the project? This is the correct place for that.


Forum rules

This forum is for feature requests, content changes additions, anything not a Bug in the software.
Please report all bugs on the Support Forums

Post Reply
User avatar
GonzoDark
Warrior
Warrior
Posts: 327
Joined: 21 Apr 2007, 09:27
Location: Denmark

Selim The Dyer

Post by GonzoDark »

I am not sure where to place this, but I am pretty sure it is a bug.

The red area is where the dialog can be initiated with the NPC, it should be in the green area.
Attachments
funnybug.png
funnybug.png (20.03 KiB) Viewed 3753 times
IchigoBlack (86) a.k.a GonzoDark (80) || HolyManaClan

Image
User avatar
Jenalya
TMW Adviser
TMW Adviser
Posts: 717
Joined: 22 Sep 2010, 19:28

Re: Selim The Dyer

Post by Jenalya »

This is the spritesheet of the dyer NPC: https://github.com/jtoelke/tmwa-client- ... c-dyer.png
As you can see, the picture contains the dyer and his equipment, both together is the entire NPC. The target cycle is placed in the middle of the NPC.
I suppose this could be avoided if the parts are seperated, so the NPC would only contain the person and the other part would be put on a tileset.
User avatar
GonzoDark
Warrior
Warrior
Posts: 327
Joined: 21 Apr 2007, 09:27
Location: Denmark

Re: Selim The Dyer

Post by GonzoDark »

Jenalya wrote:I suppose this could be avoided if the parts are seperated, so the NPC would only contain the person and the other part would be put on a tileset.
That sounds like a doable fix ;) but I don't have the skills needed.
IchigoBlack (86) a.k.a GonzoDark (80) || HolyManaClan

Image
User avatar
Alige
TMW Adviser
TMW Adviser
Posts: 1398
Joined: 09 Jan 2010, 19:22

Re: Selim The Dyer

Post by Alige »

This fix is very easy. Just add a positive offsetX in the dyer's xml file and it'll be perfect!

Ali
Image
User avatar
GonzoDark
Warrior
Warrior
Posts: 327
Joined: 21 Apr 2007, 09:27
Location: Denmark

Re: Selim The Dyer

Post by GonzoDark »

Ali-G wrote:This fix is very easy. Just add a positive offsetX in the dyer's xml file and it'll be perfect!

Ali
If you know how to do it ;) then please by all means fix it.

Thanks in advance

// GonzoDark
IchigoBlack (86) a.k.a GonzoDark (80) || HolyManaClan

Image
User avatar
Alige
TMW Adviser
TMW Adviser
Posts: 1398
Joined: 09 Jan 2010, 19:22

Re: Selim The Dyer

Post by Alige »

I just sent the intructions to Jenalya on how to fix that problem.

Ali
Image
User avatar
Villain
Novice
Novice
Posts: 104
Joined: 24 Aug 2011, 15:59
Location: California

Re: Selim The Dyer

Post by Villain »

Ali-G wrote:I just sent the intructions to Jenalya on how to fix that problem.

Ali
I see management in your future.
RIP Frost, Big Crunch, Mistakes, mrgrey, and MrWho
User avatar
Crush
TMW Adviser
TMW Adviser
Posts: 8046
Joined: 25 Aug 2005, 16:08
Location: Germany

Re: Selim The Dyer

Post by Crush »

Give someone a fish, and you feed them for a day.
Teach someone how to fish, and you feed them for life.
When someone refuses to learn a lesson and wants the free fish instead, beat them with the fish, because they deserve it.
  • former Manasource Programmer
  • former TMW Pixel artist
  • NOT a game master

Please do not send me any inquiries regarding player accounts on TMW.


You might have heard a certain rumor about me. This rumor is completely false. You might also have heard the other rumor about me. This rumor is 100% accurate.
User avatar
bcs86
Warrior
Warrior
Posts: 259
Joined: 27 Feb 2009, 17:14
Contact:

Re: Selim The Dyer

Post by bcs86 »

This patch is for
tmwa-client-data f15edb4...
Tested with Mana client 6.1

Thank you, Ali-G

[The extension diff has been deactivated and can no longer be displayed.]

User avatar
Jenalya
TMW Adviser
TMW Adviser
Posts: 717
Joined: 22 Sep 2010, 19:28

Re: Selim The Dyer

Post by Jenalya »

bcs86 wrote: This patch is for
tmwa-client-data f15edb4...
Tested with Mana client 6.1

Thank you, Ali-G
This moves the NPC just very far to the right, which looks a bit odd to me.

I pushed this using Ali-G's suggestions from the pm (offset of 30 and moving the NPCs position):
https://github.com/themanaworld/tmwa-cl ... 44f8186d3a
https://github.com/themanaworld/tmwa-se ... 2393665f39

Though I really don't get why this had to be put into a pm instead here in this topic where everyone can see it...

GonzoDark, thanks for reporting this. Ali-G, thanks for pointing out how this can be fixed. :)
Attachments
dyerMovedBy30andpositionChanged.png
dyerMovedBy30andpositionChanged.png (15.3 KiB) Viewed 3644 times
dyerMovedBy61.png
dyerMovedBy61.png (15.35 KiB) Viewed 3644 times
User avatar
bcs86
Warrior
Warrior
Posts: 259
Joined: 27 Feb 2009, 17:14
Contact:

Re: Selim The Dyer

Post by bcs86 »

I pulled 035b1ceb2... for the client data in the mainline branch but now I have the problem that Jenalya had.
Dye guy doesn't like me.
Dye guy doesn't like me.
ss-120429.jpg (6.65 KiB) Viewed 3629 times
I'm using Mana 0.6.1 (compiled from that branch, not the tarball at Manasource)
One of the notable changes to it was to animation handling to fix the dead->stand animation glitch.

Is there another explaination for this?
If not I'll keep looking.

I hope to be a bigger help than this.
User avatar
Jenalya
TMW Adviser
TMW Adviser
Posts: 717
Joined: 22 Sep 2010, 19:28

Re: Selim The Dyer

Post by Jenalya »

bcs86 wrote:I pulled 035b1ceb2... for the client data in the mainline branch but now I have the problem that Jenalya had.
I also moved the NPC one tile to the left in its script, so you need to use the corresponding server-data version to see it in the correct position.
I just restarted the testserver with the latest version, so it can be seen there. :)
User avatar
bcs86
Warrior
Warrior
Posts: 259
Joined: 27 Feb 2009, 17:14
Contact:

Re: Selim The Dyer

Post by bcs86 »

Jenalya,
Acknowledged, this seems a little better.

The next step might be to separate these two things.
That would involve moving it to either an available or a new tileset.
Unless something could be added, the task might be a little meager.
User avatar
Alige
TMW Adviser
TMW Adviser
Posts: 1398
Joined: 09 Jan 2010, 19:22

Re: Selim The Dyer

Post by Alige »

bcs86 wrote:The next step might be to separate these two things.
I see no reason to do that.
Image
Post Reply