I've finished my initial cleanup of the common/ objects, I need to do the login and char servers (integrating SQL with the TXT versions, so they don't diverge again - I am NOT looking forward to this) and do the map server and possibly ladmin.
It would be helpful to know what, if any, of the tool/ are actually used, or would be appreciated.
This is not a general request for feature requests, at this time, but I expect I will add some high value, low cost features such as split menus in scripts.
---
An interesting story: when I rewrote the MD5 code, I introduced the following bug, which didn't show up during testing, but only when I added the code to tmwAthena. Can you see the bug? (it is for things like this that I hate C).
(PjotrOrial got it on IRC)
Code: Select all
MD5_state MD5_from_string(const char* msg, const size_t msglen)
{
...
uint8_t buf[0x40];
...
// append the message length, in bits
for (int i=0; i<8; i++)
buf[0x38+i] = (8*msglen) >> (i*8);
...
}