While writing this I noticed that our version of check_weight does not do as the upstream eA document says (check for inventory space), but only check the weight. Still, it should be used ... perhaps we could write a wrapper function that calls both?
As far as I can tell "callfunc" and "callsub" should work with arguments and return values ...
Note: this page intentionally is called eAthena rather than tmwAthena, as that is whence the language is. I'm planning on a purer language for tmwA.
Note: I wrote this while referring to my rewrite branch, but I have tried to keep it generic. Anything that I may have changed should be noted as "deprecated".
Here are some ways it should be improved:
- Sort commands into categories. A page with 142 sections is difficult.
- Add operators, and general information about the script syntax, some of it moved from EAthena Scripting Standards? The "Standards" page should only mention our standards for using the language; this (or perhaps another) page should be a reference of what the language is.
- wikify: replace some of my awkward syntax with templates, etc. ... Also I'm thinking of (eventually) adding a links to the packets table (which also needs updating, but probably not by you mortals)
- Double-check method signatures. Mostly I am concerned that I might have forgotten to change some from command syntax to function syntax (check if it mentions a return value). It is also possible that, since I worked from the source code implementation, ignoring the signature strings (which were quite often wrong!), that there are some arguments that must be passed, but which are ignored.
- Examples? I'm not sure whether that is suitable for this page - wouldn't it bloat the page even more?
- Improve the descriptions - they were written by me, understood by me, but perhaps not all suitable for a nontechnical developer.
- Test whether functions actually work.