About Upmarmu

[kereszte]

Recently, it was discovered that upmarmu is a server-wide bug. This is painful as more people would like to play it.

I did some digging and came up with this:

https://git.themanaworld.org/legacy/ser ... 24b20a2ea3

So there's a casterid that was treated as a global variable, and, for some reason, it was getting overwritten by anybody casting upmarmu.

My fix is simple, remove the global variable and replace usage with a call to get the char's id in the OnTimer25000 function. This both uses one less global variable and more closely mimics other scripts.

ok trying again, this simplifies quite a bit:

https://git.themanaworld.org/legacy/ser ... quests/721

questions? comments?
AJ

[jesusalva]

No idea why that timer exists or why they used initnpctimer instead of addtimer (nor if it's using duplicate properly, eg. Kaflosh uses NPC variables — the dot prefix — because each cast creates a duplicate NPC) but 721 looks valid~ish.

You'll need to poke HoraK and Ledmitz, most likely.

[Ledmitz]

Consider me poked. I'll pass it along to HoraK to look at and thank you.