Error while compiling for Debian amd64 with gcc 4.0

moi1392 · Post by **moi1392** » 15 Jul 2005, 14:50

I got an error because in guichan, the class ModelList declare a pure virtual and is not implemented.
The linker fail in gui/byu.o when is looking for the super class destructor (ListModel)

I simply add these line at the end of this file (buy.cpp) :

Code: Select all

namespace gcn
{
	ListModel::~ListModel()
	{
	}
}

Post by **Bjørn** » 15 Jul 2005, 16:25

OK, thanks for this workaround. We'll make sure to include that as long as Guichan 0.5.0 isn't out yet.

One thing though, will it work with Guichan CVS that does define the ListModel destructor?

moi1392 · Post by **moi1392** » 15 Jul 2005, 16:39

sorry for not saying this before : I use guichan CVS (I check it out yesterday)

Post by **Bjørn** » 17 Jul 2005, 14:27

If it's a problem with Guichan CVS, then Guichan CVS should be fixed and I won't add the workaround to TMW. I've told a Guichan developer about this problem. Latest TMW version and TMW CVS should work fine with Guichan 0.4.0.

nym · Post by **nym** » 19 Jul 2005, 01:13

This problem was fixed not long after the 0.4 release and is available in Guichan CVS. If you are using Guichan CVS and are missing the virtual destructor from ListModel, something is wrong and you should re-checkout the Guichan CVS repositry. If you want to use Guichan 0.4 there is a simple patch you can apply to make it usable with gcc4:

http://satgnu.org/nym/guichan/guichan-0.4.0.patch

just use: patch -p0 < guichan-0.4.0.patch

moi1392 · Post by **moi1392** » 20 Jul 2005, 16:06

yeah, I know the bug fixed by your patch, that's was the way I switch to cvs !!
But event if the desctructor is declared, It must be implemented if some class inherit from that one because it needed !

moi1392 · Post by **moi1392** » 02 Aug 2005, 12:05

bug fixed in guichan CVS