[FND] [REVIEW] Code+Icons for Image buttons
Re: [REQ] Icons for Image buttons
Since this will be stateful, we still need to plan out how the states will be specified.Bertram wrote:Hi jaxad,
Could we already upgrade the button class to make it optionally accept icons?
We could already play with the icon give so far, then?
What do you think about it?
Best regards.
Re: [REQ] Icons for Image buttons
Just messing with a few more options. I will continue this theme if anyone likes it.
- Attachments
-
- button-delete.png (1.03 KiB) Viewed 4272 times
-
- button-ok.png (1.14 KiB) Viewed 4272 times
-
- button2.png (768 Bytes) Viewed 4272 times
Re: [REQ] Icons for Image buttons
I noticed the x button is normally smaller? It also only has one view.
- Attachments
-
- close_button.png (707 Bytes) Viewed 4243 times
-
- close_button.png (676 Bytes) Viewed 4244 times
Re: [REQ] Icons for Image buttons
some new buttons I may want to rethink these.
There is no sensible Register Graphic. I could also make the OK a thumbs up but It's pointless sense OK fits perfectly and is very understandable by the user.
There is no sensible Register Graphic. I could also make the OK a thumbs up but It's pointless sense OK fits perfectly and is very understandable by the user.
- Attachments
-
- button-Register.png (1.26 KiB) Viewed 4241 times
-
- button-smile.png (1.15 KiB) Viewed 4242 times
-
- button-New.png (944 Bytes) Viewed 4242 times
Re: [REQ] Icons for Image buttons
Im going to continue my work encase there ever needs to be other option. besides its not a theme we are exactly looking for but more like not overlapping buttons?
Re: [REQ] Icons for Image buttons
Hi there,
To Jaxad:
We are, at least for now, looking for the icon itself, the button around is taken from the theme somewhere else and is already designed for the gray theme (and for the wood theme, btw.) We won't change them to fit the icons.
-> Or do you want (later and in another thread) to make a new custom theme for personal purpose?
Anyhow, you'll have to separate the icons from the buttons, and your buttons attempts will be unfortunately ignored for the current themes.
IMHO, apart from the buttons around:
- Generally, base your work experience if possible on ivy's work, since we mostly agreed on it: (They are icons without background higher in the thread.)
- For instance, the ok button is better by simply using this common sign: - The smily would be ok, but we've already got it by Ivy.
- The 'new' button, as for me, has a nice choice of color, but maybe doesn't fit well with the other buttons.
- The cross won't fit, because it is rather the same than the current one.
- The delete button is a nice idea but look more like soap IMHO. Maybe show it erase something?
Thanks for putting efforts on them.
Best regards.
To Jaxad:
-> Warning: Quick and dirty comment!TMW will be using a wood theme.
We are, at least for now, looking for the icon itself, the button around is taken from the theme somewhere else and is already designed for the gray theme (and for the wood theme, btw.) We won't change them to fit the icons.
-> Or do you want (later and in another thread) to make a new custom theme for personal purpose?
Anyhow, you'll have to separate the icons from the buttons, and your buttons attempts will be unfortunately ignored for the current themes.
IMHO, apart from the buttons around:
- Generally, base your work experience if possible on ivy's work, since we mostly agreed on it: (They are icons without background higher in the thread.)
- For instance, the ok button is better by simply using this common sign: - The smily would be ok, but we've already got it by Ivy.
- The 'new' button, as for me, has a nice choice of color, but maybe doesn't fit well with the other buttons.
- The cross won't fit, because it is rather the same than the current one.
- The delete button is a nice idea but look more like soap IMHO. Maybe show it erase something?
Thanks for putting efforts on them.
Best regards.
Re: [REQ] Icons for Image buttons
no problem. Yea the idea is more a custom theme. I could possibly make a new thread for custom themes.
Re: [REQ] Icons for Image buttons
Hi,
Bump!
The development of image buttons is mostly done in the client next to release: This isn't a mockup!
You can already test it by cloning the following repository:
http://www.gitorious.org/~bertram/mana/ ... ge-buttons
I'd like to see it finished for every buttons. Mind giving a hand?
See this image as a perfect example of what should be done:
Best regards,
Bump!
The development of image buttons is mostly done in the client next to release: This isn't a mockup!
You can already test it by cloning the following repository:
http://www.gitorious.org/~bertram/mana/ ... ge-buttons
I'd like to see it finished for every buttons. Mind giving a hand?
See this image as a perfect example of what should be done:
Best regards,
Re: [REQ] Icons for Image buttons
How are these?
Re: [REQ] Icons for Image buttons
Hi ivy,
A.M.A.Z.I.N.G!!
I'll make use of them asap and post another screenshot.
Thanks a lot Enchilado!
A.M.A.Z.I.N.G!!
I'll make use of them asap and post another screenshot.
Thanks a lot Enchilado!
Re: [REQ] Icons for Image buttons
Hi again,
As for now, this is mostly done: For the menu buttons, I had to adapt the image to have a size of 80x18 to make the buttons like similar whil not too big.
What do you think about it?
Best regards.
As for now, this is mostly done: For the menu buttons, I had to adapt the image to have a size of 80x18 to make the buttons like similar whil not too big.
What do you think about it?
Best regards.
Re: [REQ] Icons for Image buttons
I simply love it.
[FND] [REVIEW] Code+Icons for Image buttons
Hi,
To all developers, the work on the image button branch is now complete.
You can clone the following branch and try it for yourself:
http://www.gitorious.org/~bertram/mana/ ... ge-buttons
I need a review on the code before doing a merge to the mainline.
Thanks in advance for your help on this.
Best regards,
To all developers, the work on the image button branch is now complete.
You can clone the following branch and try it for yourself:
http://www.gitorious.org/~bertram/mana/ ... ge-buttons
I need a review on the code before doing a merge to the mainline.
Thanks in advance for your help on this.
Best regards,