The Mana World Forums

Qwerty Dragon wrote:Isn't this game at its root Linux, not Windows?

It's multi-plattform.

Just because you penguin petters are in the majority here (for a change ) doesn't mean you have to discriminate us windows users

Qwerty Dragon, I just tried to apply your patch and I get the error message

Applying: Some changes to what NPC Sema says to players.
error: patch failed: world/map/npc/002-4/miners.txt:7
error: world/map/npc/002-4/miners.txt: patch does not apply
Patch failed at 0001 Some changes to what NPC Sema says to players.

I also noticed that there are still tabs in the file, but we've replaced them with four spaces some time ago.
Can you please tell which repository you cloned and if it is up-to-date?

You can find some informations about the repositories we use in this sticky:
http://forums.themanaworld.org/viewtopi ... 13&t=12981

Crush wrote:Just because you penguin petters are in the majority here (for a change ) doesn't mean you have to discriminate us windows users

Yes, it does, because Windows sucks as a development environment. (so does Mac, but for a different reason)

o11c wrote:Yes, it does, because Windows sucks as a development environment. (so does Mac, but for a different reason)

Good one, you almost tricked me into a pointless operating system flamewar.

SuperTux rules.

.

Changing any command in the instructions means you are not following the instructions.

You probably had to make that change due to having an old version of git. For Ubuntu, you can upgrade to the latest release or use the PPA: https://launchpad.net/~git-core/+archive/ppa

Any up-to-date Linux distribution is suitable for development.

Also, before preparing any patches, you must do: git pull. Note that occasionally you need to pull from the tmw-eathena repository as well as tmwa-server-test

.

Qwerty Dragon wrote:I did new install successfully using information above. New attempt at patch is in attachment.

This patch works to apply.
The dialogue changes are nice, but there is some inconsistency regarding using one space on the end of a sentence or two spaces. The original version uses two spaces but some of your changes use only one.
We had a brief discussion about that in IRC and came to the conclusion that this is a matter of taste, but should be consistent within a single script. Please fix that then I can push your patch.

.

.

That takes care of pulling client data to keep it in sync with server-data.

But, for various reasons, the server sources are not automatically synchronized.

Please note that a commit about Sema's script got pushed recently. It adds the new sprite you (Qwerty Dragon) made. If you want your patch to apply correctly, you must do "git pull" first. In fact, it just changes the ID of the NPC to 340.

Regards.

Ali-G wrote:Please note that a commit about Sema's script got pushed recently. It adds the new sprite you (Qwerty Dragon) made. If you want your patch to apply correctly, you must do "git pull" first. In fact, it just changes the ID of the NPC to 340.

Since the dialog changes are on different lines in the file than the change of the ID, there is no problem with this. Though you're right that patches should in general always be based on the latest version of the testing repository.

Qwerty Dragon wrote:Made changes.

I pushed your patch.

.