[FND] [REVIEW] Code+Icons for Image buttons

All development of pixel art and graphics
User avatar
lien
Novice
Novice
Posts: 446
Joined: Thu Oct 30, 2008 9:59 am
Location: France

Re: [REQ] Icons for Image buttons

Post by lien » Sun May 30, 2010 1:45 pm

close button
Image :arrow: normal , over , pressed ,disabled
.....

Lien ...
Image
User avatar
Jaxad0127
TMW Adviser
TMW Adviser
Posts: 4209
Joined: Thu Nov 01, 2007 6:35 pm
Location: Internet

Re: [REQ] Icons for Image buttons

Post by Jaxad0127 » Tue Jun 01, 2010 5:26 pm

Bertram wrote:Hi jaxad,

Could we already upgrade the button class to make it optionally accept icons?

We could already play with the icon give so far, then?

What do you think about it?

Best regards.
Since this will be stateful, we still need to plan out how the states will be specified.
Image
User avatar
meway
Knight
Knight
Posts: 1736
Joined: Sun Jan 04, 2009 6:02 am
Location: Detroit MI
Contact:

Re: [REQ] Icons for Image buttons

Post by meway » Thu Oct 28, 2010 4:28 pm

Just messing with a few more options. I will continue this theme if anyone likes it.
Attachments
button-delete.png
button-delete.png (1.03 KiB) Viewed 1901 times
button-ok.png
button-ok.png (1.14 KiB) Viewed 1901 times
button2.png
button2.png (768 Bytes) Viewed 1901 times
User avatar
meway
Knight
Knight
Posts: 1736
Joined: Sun Jan 04, 2009 6:02 am
Location: Detroit MI
Contact:

Re: [REQ] Icons for Image buttons

Post by meway » Fri Oct 29, 2010 6:27 am

I noticed the x button is normally smaller? It also only has one view.
Attachments
close_button.png
close_button.png (707 Bytes) Viewed 1872 times
close_button.png
close_button.png (676 Bytes) Viewed 1873 times
User avatar
meway
Knight
Knight
Posts: 1736
Joined: Sun Jan 04, 2009 6:02 am
Location: Detroit MI
Contact:

Re: [REQ] Icons for Image buttons

Post by meway » Fri Oct 29, 2010 6:45 am

some new buttons I may want to rethink these.
There is no sensible Register Graphic. I could also make the OK a thumbs up but It's pointless sense OK fits perfectly and is very understandable by the user.
Attachments
button-Register.png
button-Register.png (1.26 KiB) Viewed 1870 times
button-smile.png
button-smile.png (1.15 KiB) Viewed 1871 times
button-New.png
button-New.png (944 Bytes) Viewed 1871 times
User avatar
Jaxad0127
TMW Adviser
TMW Adviser
Posts: 4209
Joined: Thu Nov 01, 2007 6:35 pm
Location: Internet

Re: [REQ] Icons for Image buttons

Post by Jaxad0127 » Fri Oct 29, 2010 7:35 am

TMW will be using a wood theme.
Image
User avatar
meway
Knight
Knight
Posts: 1736
Joined: Sun Jan 04, 2009 6:02 am
Location: Detroit MI
Contact:

Re: [REQ] Icons for Image buttons

Post by meway » Fri Oct 29, 2010 8:47 am

Im going to continue my work encase there ever needs to be other option. besides its not a theme we are exactly looking for but more like not overlapping buttons?
User avatar
Bertram
Knight
Knight
Posts: 1026
Joined: Tue Sep 07, 2004 3:55 pm
Location: France

Re: [REQ] Icons for Image buttons

Post by Bertram » Fri Oct 29, 2010 1:07 pm

Hi there,

To Jaxad:
TMW will be using a wood theme.
-> Warning: Quick and dirty comment! ;)

We are, at least for now, looking for the icon itself, the button around is taken from the theme somewhere else and is already designed for the gray theme (and for the wood theme, btw.) We won't change them to fit the icons.
-> Or do you want (later and in another thread) to make a new custom theme for personal purpose?

Anyhow, you'll have to separate the icons from the buttons, and your buttons attempts will be unfortunately ignored for the current themes.

IMHO, apart from the buttons around:
- Generally, base your work experience if possible on ivy's work, since we mostly agreed on it:
all.png
all.png (2.67 KiB) Viewed 1841 times
(They are icons without background higher in the thread.)
- For instance, the ok button is better by simply using this common sign:
button-okay.png
button-okay.png (1.97 KiB) Viewed 1841 times
- The smily would be ok, but we've already got it by Ivy.
- The 'new' button, as for me, has a nice choice of color, but maybe doesn't fit well with the other buttons.
- The cross won't fit, because it is rather the same than the current one.
- The delete button is a nice idea but look more like soap IMHO. Maybe show it erase something?

Thanks for putting efforts on them. :)

Best regards.
User avatar
meway
Knight
Knight
Posts: 1736
Joined: Sun Jan 04, 2009 6:02 am
Location: Detroit MI
Contact:

Re: [REQ] Icons for Image buttons

Post by meway » Fri Oct 29, 2010 4:13 pm

:) no problem. Yea the idea is more a custom theme. I could possibly make a new thread for custom themes.
User avatar
Bertram
Knight
Knight
Posts: 1026
Joined: Tue Sep 07, 2004 3:55 pm
Location: France

Re: [REQ] Icons for Image buttons

Post by Bertram » Tue Jul 05, 2011 12:31 am

Hi,

Bump!

The development of image buttons is mostly done in the client next to release:
Mana_Screenshot_9.png
Mana_Screenshot_9.png (32.22 KiB) Viewed 1754 times
This isn't a mockup! :D

You can already test it by cloning the following repository:
http://www.gitorious.org/~bertram/mana/ ... ge-buttons

I'd like to see it finished for every buttons. Mind giving a hand?
See this image as a perfect example of what should be done:
Image

Best regards,
User avatar
enchilado
Warrior
Warrior
Posts: 972
Joined: Fri Mar 06, 2009 2:21 am
Location: evermore a GUY

Re: [REQ] Icons for Image buttons

Post by enchilado » Tue Jul 05, 2011 2:55 am

How are these?

Image
Image
Image
Image
Image
Image
Image
Image
Image
Image
Image
Image
Image
Image
User avatar
Bertram
Knight
Knight
Posts: 1026
Joined: Tue Sep 07, 2004 3:55 pm
Location: France

Re: [REQ] Icons for Image buttons

Post by Bertram » Tue Jul 05, 2011 8:06 am

Hi ivy,

A.M.A.Z.I.N.G!! :shock: :lol: :D

I'll make use of them asap and post another screenshot.

Thanks a lot Enchilado!
User avatar
Bertram
Knight
Knight
Posts: 1026
Joined: Tue Sep 07, 2004 3:55 pm
Location: France

Re: [REQ] Icons for Image buttons

Post by Bertram » Fri Jul 15, 2011 2:04 am

Hi again,

As for now, this is mostly done:
image-buttons.png
image-buttons.png (82.45 KiB) Viewed 1652 times
For the menu buttons, I had to adapt the image to have a size of 80x18 to make the buttons like similar whil not too big.

What do you think about it? :mrgreen:

Best regards.
User avatar
Alige
Developer
Developer
Posts: 1398
Joined: Sat Jan 09, 2010 8:22 pm
Location: Weed Island

Re: [REQ] Icons for Image buttons

Post by Alige » Fri Jul 15, 2011 5:03 am

I simply love it.
Image
User avatar
Bertram
Knight
Knight
Posts: 1026
Joined: Tue Sep 07, 2004 3:55 pm
Location: France

[FND] [REVIEW] Code+Icons for Image buttons

Post by Bertram » Mon Jul 25, 2011 10:49 pm

Hi,

To all developers, the work on the image button branch is now complete.

You can clone the following branch and try it for yourself:
http://www.gitorious.org/~bertram/mana/ ... ge-buttons

I need a review on the code before doing a merge to the mainline.

Thanks in advance for your help on this.

Best regards,
Post Reply