Page 1 of 1
Selim The Dyer
Posted: 28 Apr 2012, 13:13
by GonzoDark
I am not sure where to place this, but I am pretty sure it is a bug.
The red area is where the dialog can be initiated with the NPC, it should be in the green area.
Re: Selim The Dyer
Posted: 28 Apr 2012, 14:15
by Jenalya
This is the spritesheet of the dyer NPC:
https://github.com/jtoelke/tmwa-client- ... c-dyer.png
As you can see, the picture contains the dyer and his equipment, both together is the entire NPC. The target cycle is placed in the middle of the NPC.
I suppose this could be avoided if the parts are seperated, so the NPC would only contain the person and the other part would be put on a tileset.
Re: Selim The Dyer
Posted: 28 Apr 2012, 15:31
by GonzoDark
Jenalya wrote:I suppose this could be avoided if the parts are seperated, so the NPC would only contain the person and the other part would be put on a tileset.
That sounds like a doable fix

but I don't have the skills needed.
Re: Selim The Dyer
Posted: 28 Apr 2012, 20:26
by Alige
This fix is very easy. Just add a positive offsetX in the dyer's xml file and it'll be perfect!
Ali
Re: Selim The Dyer
Posted: 28 Apr 2012, 20:31
by GonzoDark
Ali-G wrote:This fix is very easy. Just add a positive offsetX in the dyer's xml file and it'll be perfect!
Ali
If you know how to do it

then please by all means fix it.
Thanks in advance
// GonzoDark
Re: Selim The Dyer
Posted: 28 Apr 2012, 20:50
by Alige
I just sent the intructions to Jenalya on how to fix that problem.
Ali
Re: Selim The Dyer
Posted: 29 Apr 2012, 02:26
by Villain
Ali-G wrote:I just sent the intructions to Jenalya on how to fix that problem.
Ali
I see management in your future.
Re: Selim The Dyer
Posted: 29 Apr 2012, 03:31
by Crush
Give someone a fish, and you feed them for a day.
Teach someone how to fish, and you feed them for life.
When someone refuses to learn a lesson and wants the free fish instead, beat them with the fish, because they deserve it.
Re: Selim The Dyer
Posted: 29 Apr 2012, 10:41
by bcs86
This patch is for
tmwa-client-data f15edb4...
Tested with Mana client 6.1
Thank you, Ali-G
[The extension diff has been deactivated and can no longer be displayed.]
Re: Selim The Dyer
Posted: 29 Apr 2012, 11:46
by Jenalya
bcs86 wrote:
This patch is for
tmwa-client-data f15edb4...
Tested with Mana client 6.1
Thank you, Ali-G
This moves the NPC just very far to the right, which looks a bit odd to me.
I pushed this using Ali-G's suggestions from the pm (offset of 30 and moving the NPCs position):
https://github.com/themanaworld/tmwa-cl ... 44f8186d3a
https://github.com/themanaworld/tmwa-se ... 2393665f39
Though I really don't get why this had to be put into a pm instead here in this topic where everyone can see it...
GonzoDark, thanks for reporting this. Ali-G, thanks for pointing out how this can be fixed.

Re: Selim The Dyer
Posted: 29 Apr 2012, 14:22
by bcs86
I pulled 035b1ceb2... for the client data in the mainline branch but now
I have the problem that Jenalya had.

- Dye guy doesn't like me.
- ss-120429.jpg (6.65 KiB) Viewed 3946 times
I'm using Mana 0.6.1 (compiled from that branch, not the tarball at Manasource)
One of the notable changes to it was to animation handling to fix the dead->stand animation glitch.
Is there another explaination for this?
If not I'll keep looking.
I hope to be a bigger help than this.
Re: Selim The Dyer
Posted: 29 Apr 2012, 15:50
by Jenalya
bcs86 wrote:I pulled 035b1ceb2... for the client data in the mainline branch but now I have the problem that Jenalya had.
I also moved the NPC one tile to the left in its script, so you need to use the corresponding server-data version to see it in the correct position.
I just restarted the testserver with the latest version, so it can be seen there.

Re: Selim The Dyer
Posted: 29 Apr 2012, 18:27
by bcs86
Jenalya,
Acknowledged, this seems a little better.
The next step might be to separate these two things.
That would involve moving it to either an available or a new tileset.
Unless something could be added, the task might be a little meager.
Re: Selim The Dyer
Posted: 29 Apr 2012, 19:46
by Alige
bcs86 wrote:The next step might be to separate these two things.
I see no reason to do that.