The Mana World Forums

Hi everyone l give my quest to The Mana World. l'm New to scripts.

Printed....


file:///C:/Users/INTEL/Pictures/mana/Desert%20Helmet%20Printed.png

Some technical problems that should be fixed (I am not considering storyline/balance issues yet):

• The file has CRLF, not LF terminators. I think this might just be the forum, though (and it's easy enough to fix).
• File name has spaces.
• Bad indentation. All indentation should be 4 spaces, there should be no tabs.
• Lots of spelling/grammar issues. A good working knowledge of the English language is essential for doing anything on the internet. We can correct specifics, but there are currently too many for me to want to deal with it.
• We no longer put square brackets around item names.
• Don't use countitem > 11, use countitem >= 12 - and use a named constant instead of a literal.
• Use bitmasking. We have lots of variables that are only partially used.
• The logic for the jump from L_Check2 to L_Progress2 is wrong
• The L_noRoom check should test whether the delitem will erase all the items from one of the slots. Actually, since equipment doesn't stack at all, the check is not needed (but a comment about why it is unneeded should be left)

Psychodelic wrote:file:///C:/Users/INTEL/Pictures/mana/Desert%20Helmet%20Printed.png

When you want to post an image from your own computer, use the "Upload attachment" feature. When you write or edit a forum post, you can find it below the message body text input.