jesusalva wrote: ↑11 Oct 2022, 14:42
1) Yes, wrong tiled version is the sole and only reason it wasn't merged
2) As it should, in ManaPlus. M+ should run from Tiled 0.5 or so without issues.
3) Old tiled does not add fields, new tiled does. And XML is a picky format, so other tools (like converters, parsers, shiny silver bullets, whatever) will notice the missing fields and moan.
Sry but you've stumbled on mage belonging to some funny school of magic. I'm quite sure I can stand my points on technical level.
1) IMO its ourtght stupid reason, inconvenient if not hostile to new contributor who wanted to make our world better.
2) If this comes to it, okay, I'll waste a bit more of my time. I've investigated further. TMW stll uses plenty of maps in 1.0 format. So I guess whole pipeline can swallow it.
3) TBH I never doubted of code quality of silver bullets and something, it always matched my wildest expectations. But even then, all this stuff somehow lives with "2)" to the date. I dont get how +/- 1 map in 1.0 format changes that, there're plenty others. So if tools moaned you should have ton of that long before Wellvin came with his map...
Remember that Wellvin is downgrading the map version. So the meaning is inverted, unless you use a colored markup:
Yes he does and most unusual thing is fact it mostly ADDS few (relatively useless and harmlsee) extra fields. Most sane XML parsers would just ignore it if they dont need it. Not to mention TMW still haves plenty of 1.0 maps to the date. Tiled started quick version bumping only few years ago. And even then it doesn't seems to be something really major down to format level.
One of beauty of using local tools is that its me who decides what sides are convenient to me so no "inversion" and I can haz quite sane view of what's going on the way it maps my brain better.
Another interesting thing I can do project-widea analisys of map version and so on to verify some claims. I just did. Guess what.
To be honest, if you have an up-to-date Tiled, all you need to do is resave it and it should hopefully fix everything. Anyone could do it in theory, provided they have enough time, interest and willpower to do so
To be honest, to me it looks like if in this particular case ppl were eating brain of new contributor for NOTHING. It took 2 months. And all that to add damn sign to building. And when it comes to map versions TMW still got some 1.0 format maps. So everything lives just fine with it, eh?
So if we're about being honest, I have impression Wellvin faced ton of inconvencies out of nowhere. Furthermore, same stands true for most Linux contributors using tiled from their distro repos.
(I don't have any of these three right now, but may have later)
TBH to me it looks like like ppl created problem out of nothing in first place. There was no such problem Jes, you've invented it yourself. But I've solved it anyway, building tiled 1.4.1 and resaving map. So zip in previous message holds updated TMX. But realistically its been very pointless tantrum to bump few numbers. It doesn't changes anything.
“Please use the latest software and tools, or at least the same everyone here uses, so we at least are on the same page if things goes downhill” is hardly an unwelcome message.
1) It dooms Linux contributors to a lot of unnecessary tantrums out of nowhere instead of installing tiled from repos and happily using it. So you break contributor experience here.
2) I've investigated map versions a bit and there're different ones, down to 1.0 (it didnt had exact tiled version by then it seems). So whole thing had to live with 1.0 maps anyway, Wellvin haven't made it any worse.
3) TMW uses assorti of map versions, there're plenty of 1.0 as well. At which point I wonder how "everyone" defined in this case given assorti of maps. I'd say 1.0 could fit this bill just as well, no?
C'mon, Tiled is on 1.9 already, it was five years ago since Tiled 1.0 release and I can't recall a stable supported distro which still has it except for Ubuntu 18.04 Extended Support which exists to support servers. No excuses!
I don't see use of tiled from repos of Lubuntu 18.04 or so as major crime given there's plenty of 1.0 maps in TMW - this map isnt any worse than any and there was no data loss, I've investigated that. So WTF, seriously?
Not only that, but in the long run, not pointing out to update the software is slightly worse. Remember that all FLOSS devs are butes. When a dev start screaming about disrespecting the world map layout which did not exist prior to Tiled 1.4, then it would be unwelcome.
There's such thing as compatibility and interop. Ruining it without MAJOR gain to justify that is silly and causes a lot of trouble and aggravation out of nowhere. Then ppl lecture me about welcoming new contributors on IRC... I think there's something doesn't matches, eh?
Having a standard minimum version on development team allows to ensure everyone have minimum features e.g. World map, and aids aligning expectations between everyone involved.
And given I see 1.0 maps in TMW, what this "standard" could be?
Whatever. I'm rambling.
And valid technical justification could be like what? How about exact fields you needed, exact versions with sane justification of features they got vs older ones or something? I think these are right questions to ask after seeing someone turned down for 2 months? Doubly so after I investigated the matter. Esp after being lectured in IRC about welcoming new contributors.