Page 1 of 1

(Bug/Fix)(MERGED) ManaVerse / ManaPlus Job Xp bar not updating

Posted: 08 May 2024, 01:27
by asuratva

As the title states, the Job Xp bar is not updating in the "Mini" status windows on the top left. It's a simple fix in "gui/windows/ministatuswindow.cpp"

At around line 277, the "StatusWindow::updateJobBar(mJobBar, true);" needs to be moved from "void MiniStatusWindow::statChanged(...)" to "void MiniStatusWindow::attributeChanged(...)" with some additional "switch case" statements thrown in.

I've attached a patch created with "git diff -p"

Not sure who, or even if anyone, is maintaining this, but please fix :)

Apologies if this is the wrong place to be posting this.


Re: (Bug/Fix) ManaVerse / ManaPlus Job Xp bar not updating

Posted: 09 May 2024, 09:17
by Reid

Hey asuratva,

Current development of the game client is currently held here: https://git.themanaworld.org/mana/plus
If you want, we would gladly welcome a patch through the merge request system!

Aside from that, there are some on-going work to revive the previous main client named Mana by Bjorn, if you are interested in that, you can check it here: https://git.themanaworld.org/mana/mana


Re: (Bug/Fix) ManaVerse / ManaPlus Job Xp bar not updating

Posted: 09 May 2024, 10:26
by ThinkSome

Hello,

Please make a commit and use git format-patch instead of git diff, this way the authorship field is properly filled out by you.


Re: (Bug/Fix) ManaVerse / ManaPlus Job Xp bar not updating

Posted: 09 May 2024, 12:56
by asuratva

Thanks for the replies.

Just created an A/c on git.themanaworld.org, it's pending approval.

Meanwhile, here's the patch created with git format-patch


Re: (Bug/Fix) ManaVerse / ManaPlus Job Xp bar not updating

Posted: 09 May 2024, 23:40
by ThinkSome

Ah nice. Then I'll wait for MR :).


Re: (Bug/Fix) ManaVerse / ManaPlus Job Xp bar not updating

Posted: 10 May 2024, 02:28
by asuratva
ThinkSome wrote: 09 May 2024, 23:40

Ah nice. Then I'll wait for MR :).

MR sent :)


Re: (Bug/Fix) ManaVerse / ManaPlus Job Xp bar not updating

Posted: 10 May 2024, 21:17
by Ledmitz

Sorry for any delay. You were added to git last night Asuralva. :)