ManaPlus - Official TMW Client v1.6.4.23

Development discussions for Manaplus (Evol's official client) and alternative clients.
User avatar
Dark_Mag
Novice
Novice
Posts: 347
Joined: 18 Dec 2009, 21:14
Contact:

Re: TMW Client Patch

Post by Dark_Mag » 28 Mar 2010, 13:32

i wrote:Dark_Mag would you be so nice and die in car accident again?
Hm... I thought that I've never dead in car acident, because of I'm online...

But my brother did...
Image
Image
4144
Client Developer
Client Developer
Posts: 924
Joined: 03 Aug 2009, 12:57

Re: TMW Client Patch

Post by 4144 » 14 Apr 2010, 16:08

New client version.

Added personal shops.
Now client by default trying avoid current server bugs.
Many other changes. look to http://tmw.cetki.com/4144/
User avatar
Bertram
Knight
Knight
Posts: 1026
Joined: 07 Sep 2004, 15:55
Location: France

Re: TMW Client Patch

Post by Bertram » 14 Apr 2010, 17:58

Hi 4144,

Can you tell more about those ones?
How does the features work? Are the speed improvements good for mainline?

Thanks in advance:

Release: 1.0.4.14.
- add: personal shop.
To this shop player can add items for buy/sale.
Other players can use it by selecting in context menu buy or sale.
To open own shop window you can press Shop button in inventory or press Shop Key.

- add: speed improvement.

Release: 1.0.3.21.
add: small speed optimisations.

Release: 0.12.
- add: afk mode. ([2])
change : SET / other / Enable afk message
use: key 2 on numeric keuboard or chat command /away TEXT. (or /away)

Regards.
4144
Client Developer
Client Developer
Posts: 924
Joined: 03 Aug 2009, 12:57

Re: TMW Client Patch

Post by 4144 » 14 Apr 2010, 19:39

Bertram wrote:Hi 4144,
Hi,
Bertram wrote: Can you tell more about those ones?
How does the features work? Are the speed improvements good for mainline?
Speed improvements in last version i think is caching being names, levels and some other parameters. Client not send every time 0x0094 message if being already was saw.
In 1.0.3.21 i not remember, need look to commits log.
Bertram wrote: Thanks in advance:

Release: 1.0.4.14.
- add: personal shop.
To this shop player can add items for buy/sale.
Other players can use it by selecting in context menu buy or sale.
To open own shop window you can press Shop button in inventory or press Shop Key.
Personal shops working over whisper messages to exchage info.
I think is good add this feature to main line client, but now manaserv on test server not support invetory and as result i can only test this code for eAthena.
Code is bit complex, may be not all devs like as i doing this :)
Bertram wrote: - add: speed improvement.

Release: 1.0.3.21.
add: small speed optimisations.

Release: 0.12.
- add: afk mode. ([2])
change : SET / other / Enable afk message
use: key 2 on numeric keuboard or chat command /away TEXT. (or /away)
If i create patches for this features they will be added to main line?
User avatar
Bertram
Knight
Knight
Posts: 1026
Joined: 07 Sep 2004, 15:55
Location: France

Re: TMW Client Patch

Post by Bertram » 14 Apr 2010, 22:35

Hi,
Hi! (At last someone being polite, even on forums ;) )
Speed improvements in last version i think is caching being names, levels and some other parameters. Client not send every time 0x0094 message if being already was saw.
:arrow: I can't find such message in src/net/ea/protocol.h for mainline and I can't put my hand back to the protocol in the eAthena svn. What does this message 0x0094 do, already?
Personal shops working over whisper messages to exchange info.
I think is good add this feature to main line client, but now manaserv on test server not support inventory and as result i can only test this code for eAthena.
Code is bit complex, may be not all devs like as i doing this :)
:arrow: Indeed, code specially made for tEathena should be carefully enclosed with such kind of code:

Code: Select all

if (Net::getNetworkType() == ServerInfo::EATHENA)
{
...
}
else if (Net::getNetworkType() == ServerInfo::MANASERV) // <-- !
...
but I'm not teaching you something new ;)
Inventory in ManaServ is working for self inventory. Trading is also 95% functional (Canceling trading is currently well handled for the server, but not by the client.). The ManaServ Testing server is unfortunately not a big help as it is very slow most of the time.
So if you can enclose the shop code to be enabled only for eAthena for now, I'll be your reviewer. :)
ManaServ already has premises of an auction system, still to be reviewed and finished.

Oh, I'm planning to rename the EATHENA value to TMWATHENA. The true EATHENA protocol is planned to be supported, for the current features only in a first time.
If i create patches for this features they will be added to main line?
:arrow: If you can separate your patches for AFK and speed improvements, I'll gladly review them, with the help of any other mana developer. If they're ok, I can't why they shouldn't go in, for eathena, at least.
As for ManaServ, I'll try to bring the same features, but handled more by the server if possible. An afk mode for ManaServ is rather easily feasible, I'd say.

Regards.
4144
Client Developer
Client Developer
Posts: 924
Joined: 03 Aug 2009, 12:57

Re: TMW Client Patch

Post by 4144 » 15 Apr 2010, 01:25

Bertram wrote: Hi! (At last someone being polite, even on forums ;) )
Hi.
Bertram wrote:
Speed improvements in last version i think is caching being names, levels and some other parameters. Client not send every time 0x0094 message if being already was saw.
:arrow: I can't find such message in src/net/ea/protocol.h for mainline and I can't put my hand back to the protocol in the eAthena svn. What does this message 0x0094 do, already?
It's unnamed packet, for example you can find it here src/net/ea/beinghandler.cpp:91
Bertram wrote:
If i create patches for this features they will be added to main line?
:arrow: If you can separate your patches for AFK and speed improvements, I'll gladly review them, with the help of any other mana developer. If they're ok, I can't why they shouldn't go in, for eathena, at least.
As for ManaServ, I'll try to bring the same features, but handled more by the server if possible. An afk mode for ManaServ is rather easily feasible, I'd say.

Regards.
Afk may work in client side only for both server, but now i have code only for eathena.

Ok I will try extract this features in separate patches.
User avatar
Jaxad0127
TMW Adviser
TMW Adviser
Posts: 4209
Joined: 01 Nov 2007, 18:35
Location: Internet

Re: TMW Client Patch

Post by Jaxad0127 » 15 Apr 2010, 06:01

4144 wrote:...caching being names.... Client not send every time 0x0094 message if being already was saw.
I'm a little worried about that one. Since players are identified by account number, it's impossible to tell two characters on the same account apart, save for the name packet. So, if you see one character from the account and later see another from the account, will the second one be given the first one's name?
Image
4144
Client Developer
Client Developer
Posts: 924
Joined: 03 Aug 2009, 12:57

Re: TMW Client Patch

Post by 4144 » 15 Apr 2010, 10:07

jaxad0127 wrote:
4144 wrote:...caching being names.... Client not send every time 0x0094 message if being already was saw.
I'm a little worried about that one. Since players are identified by account number, it's impossible to tell two characters on the same account apart, save for the name packet. So, if you see one character from the account and later see another from the account, will the second one be given the first one's name?
Yes, it's small disadvantage of this. Current cache size is 50 beings.
User avatar
Dark_Mag
Novice
Novice
Posts: 347
Joined: 18 Dec 2009, 21:14
Contact:

Re: TMW Client Patch

Post by Dark_Mag » 18 Apr 2010, 02:49

I made new type of theme called "Wood". New backgrounds and some sprites from old one.

Also: How can I pos <filename>.zip?

Image
Image
Image
User avatar
Rotonen
TMW Adviser
TMW Adviser
Posts: 3154
Joined: 08 Sep 2004, 20:48
Location: Espoo, Finland

Re: TMW Client Patch

Post by Rotonen » 18 Apr 2010, 13:05

Unreadable -> unusable.

A GUI should not be primarily an attempt to be an art statement (or a revisioning of the 60's). It should be simple and practical. If you can also make it pretty when accomplishing this, all the better.
This message used to be meaningful.
4144
Client Developer
Client Developer
Posts: 924
Joined: 03 Aug 2009, 12:57

Re: TMW Client Patch

Post by 4144 » 18 Apr 2010, 15:00

Dark_Mag wrote:I made new type of theme called "Wood". New backgrounds and some sprites from old one.

Also: How can I pos <filename>.zip?
Yes text may be unredable. And wood theme already exists, need new name.
User avatar
Dark_Mag
Novice
Novice
Posts: 347
Joined: 18 Dec 2009, 21:14
Contact:

Re: TMW Client Patch

Post by Dark_Mag » 20 Apr 2010, 21:50

Iced Blue Theme. I remade everything in its type.

Image
Image
Image
User avatar
Rotonen
TMW Adviser
TMW Adviser
Posts: 3154
Joined: 08 Sep 2004, 20:48
Location: Espoo, Finland

Re: TMW Client Patch

Post by Rotonen » 21 Apr 2010, 16:26

Tiling issues. But the approach is better. Why the gradient?
This message used to be meaningful.
4144
Client Developer
Client Developer
Posts: 924
Joined: 03 Aug 2009, 12:57

Re: TMW Client Patch

Post by 4144 » 25 Apr 2010, 22:50

New patch version.
4144
Client Developer
Client Developer
Posts: 924
Joined: 03 Aug 2009, 12:57

Re: TMW Client Patch

Post by 4144 » 01 May 2010, 16:35

New client version.
Post Reply