(Bug/Fix)(MERGED) ManaVerse / ManaPlus Job Xp bar not updating

Development discussions for TMW's official client, alternative clients and client adaptations.


Post Reply
User avatar
asuratva
Peon
Peon
Posts: 16
Joined: 24 Jun 2022, 09:37

(Bug/Fix)(MERGED) ManaVerse / ManaPlus Job Xp bar not updating

Post by asuratva »

As the title states, the Job Xp bar is not updating in the "Mini" status windows on the top left. It's a simple fix in "gui/windows/ministatuswindow.cpp"

At around line 277, the "StatusWindow::updateJobBar(mJobBar, true);" needs to be moved from "void MiniStatusWindow::statChanged(...)" to "void MiniStatusWindow::attributeChanged(...)" with some additional "switch case" statements thrown in.

I've attached a patch created with "git diff -p"

Not sure who, or even if anyone, is maintaining this, but please fix :)

Apologies if this is the wrong place to be posting this.

Attachments
fix-jobbar.zip
(556 Bytes) Downloaded 86 times

Chars: SIGSEGV, LeChuck, Halfwit, Xyzzy, Darknetizen, asuratva

User avatar
Reid
Lead Developer (SoM)
Lead Developer (SoM)
Posts: 1555
Joined: 15 May 2010, 21:39
Location: Artis
Contact:

Re: (Bug/Fix) ManaVerse / ManaPlus Job Xp bar not updating

Post by Reid »

Hey asuratva,

Current development of the game client is currently held here: https://git.themanaworld.org/mana/plus
If you want, we would gladly welcome a patch through the merge request system!

Aside from that, there are some on-going work to revive the previous main client named Mana by Bjorn, if you are interested in that, you can check it here: https://git.themanaworld.org/mana/mana

"Time is an illusion. Lunchtime doubly so."
-- Ford Prefect
ThinkSome
Moubootaur Legends
Moubootaur Legends
Posts: 85
Joined: 02 Apr 2023, 16:47

Re: (Bug/Fix) ManaVerse / ManaPlus Job Xp bar not updating

Post by ThinkSome »

Hello,

Please make a commit and use git format-patch instead of git diff, this way the authorship field is properly filled out by you.

User avatar
asuratva
Peon
Peon
Posts: 16
Joined: 24 Jun 2022, 09:37

Re: (Bug/Fix) ManaVerse / ManaPlus Job Xp bar not updating

Post by asuratva »

Thanks for the replies.

Just created an A/c on git.themanaworld.org, it's pending approval.

Meanwhile, here's the patch created with git format-patch

Attachments
patchfile.zip
(837 Bytes) Downloaded 53 times

Chars: SIGSEGV, LeChuck, Halfwit, Xyzzy, Darknetizen, asuratva

ThinkSome
Moubootaur Legends
Moubootaur Legends
Posts: 85
Joined: 02 Apr 2023, 16:47

Re: (Bug/Fix) ManaVerse / ManaPlus Job Xp bar not updating

Post by ThinkSome »

Ah nice. Then I'll wait for MR :).

User avatar
asuratva
Peon
Peon
Posts: 16
Joined: 24 Jun 2022, 09:37

Re: (Bug/Fix) ManaVerse / ManaPlus Job Xp bar not updating

Post by asuratva »

ThinkSome wrote: 09 May 2024, 23:40

Ah nice. Then I'll wait for MR :).

MR sent :)

Chars: SIGSEGV, LeChuck, Halfwit, Xyzzy, Darknetizen, asuratva

User avatar
Ledmitz
TMW Classic
TMW Classic
Posts: 591
Joined: 17 Aug 2011, 22:40
Location: The Mana World
Contact:

Re: (Bug/Fix) ManaVerse / ManaPlus Job Xp bar not updating

Post by Ledmitz »

Sorry for any delay. You were added to git last night Asuralva. :)

Ledmitz = Ardits = KillerBee = Mystic = Mystical_Servant = Tipsy Skeleton = BoomBoom = Cloak

Post Reply