MiniMap Bug & Fix

[leeor_net]

I noticed a bug in the Minimap while testing the SVN Client (0.1.0 trunk). I haven't noticed this being addressed in any of the SVN updates and the change to the code is so small I didn't think a patch would be necessary:

File: gui/minimap.cpp -- Line: 108 -- Function: void Minimap::draw(gcn::Graphics *graphics)

Code: Select all

            case Being::NPC:
                graphics->setColor( gcn::Color(255, 255, 0) );
                break;

            default:
                // If we're here we missed something
                assert( (being->getType() == Being::PLAYER) || (being->getType() == Being::MONSTER) || (being->getType() == Being::NPC) );
                break;

Hope that helps.

[Crush]

Thanks for reporting and fixing. Unfortunately I can't take care of this right now. So I'll put it on the bugtracker nevertheless because otherwise it will most likely be forgotten.

Just curious: What exactly is the bug?

[Bjørn]

I don't see any reason to add an assertion, since that would just cause the program to terminate for no good reason (supposing we had missed something). Other than that I understand you're having NPCs drawn in yellow, while before their color was defined by the last thing drawn before the NPC.

[leeor_net]

I don't see any reason to add an assertion, since that would just cause the program to terminate for no good reason (supposing we had missed something). Other than that I understand you're having NPCs drawn in yellow, while before their color was defined by the last thing drawn before the NPC.

Assertions on Win32 still allows a program to keep moving -- I forgot it doesn't work like that on *nix systems. Actually, I'm not sure why I found it necessary to put it there.

As for the NPC's being drawn as the last being drawn, that would be the 'bug'. Why would you want NPC dots to be drawn in Red while near monsters or Blue while near players? As for the color itself, I just thought anything contrasting would work.