[FND] [REVIEW] Code+Icons for Image buttons

[lien]

close button
normal , over , pressed ,disabled
.....

Lien ...

[Jaxad0127]

Hi jaxad,

Could we already upgrade the button class to make it optionally accept icons?

We could already play with the icon give so far, then?

What do you think about it?

Best regards.

Since this will be stateful, we still need to plan out how the states will be specified.

[meway]

Just messing with a few more options. I will continue this theme if anyone likes it.

[meway]

I noticed the x button is normally smaller? It also only has one view.

[meway]

some new buttons I may want to rethink these.
There is no sensible Register Graphic. I could also make the OK a thumbs up but It's pointless sense OK fits perfectly and is very understandable by the user.

[Jaxad0127]

TMW will be using a wood theme.

[meway]

Im going to continue my work encase there ever needs to be other option. besides its not a theme we are exactly looking for but more like not overlapping buttons?

[Bertram]

Hi there,

To Jaxad:

TMW will be using a wood theme.

-> Warning: Quick and dirty comment!

We are, at least for now, looking for the icon itself, the button around is taken from the theme somewhere else and is already designed for the gray theme (and for the wood theme, btw.) We won't change them to fit the icons.
-> Or do you want (later and in another thread) to make a new custom theme for personal purpose?

Anyhow, you'll have to separate the icons from the buttons, and your buttons attempts will be unfortunately ignored for the current themes.

IMHO, apart from the buttons around:
- Generally, base your work experience if possible on ivy's work, since we mostly agreed on it:

all.png (2.67 KiB) Viewed 5116 times

(They are icons without background higher in the thread.)
- For instance, the ok button is better by simply using this common sign:

button-okay.png (1.97 KiB) Viewed 5116 times

- The smily would be ok, but we've already got it by Ivy.
- The 'new' button, as for me, has a nice choice of color, but maybe doesn't fit well with the other buttons.
- The cross won't fit, because it is rather the same than the current one.
- The delete button is a nice idea but look more like soap IMHO. Maybe show it erase something?

Thanks for putting efforts on them.

Best regards.

[meway]

no problem. Yea the idea is more a custom theme. I could possibly make a new thread for custom themes.

[Bertram]

Hi,

Bump!

The development of image buttons is mostly done in the client next to release:

Mana_Screenshot_9.png (32.22 KiB) Viewed 5029 times

This isn't a mockup!

You can already test it by cloning the following repository:
http://www.gitorious.org/~bertram/mana/ ... ge-buttons

I'd like to see it finished for every buttons. Mind giving a hand?
See this image as a perfect example of what should be done:


Best regards,

[enchilado]

How are these?

[Bertram]

Hi ivy,

A.M.A.Z.I.N.G!!

I'll make use of them asap and post another screenshot.

Thanks a lot Enchilado!

[Bertram]

Hi again,

As for now, this is mostly done:

image-buttons.png (82.45 KiB) Viewed 4927 times

For the menu buttons, I had to adapt the image to have a size of 80x18 to make the buttons like similar whil not too big.

What do you think about it?

Best regards.

[Alige]

I simply love it.

[Bertram]

Hi,

To all developers, the work on the image button branch is now complete.

You can clone the following branch and try it for yourself:
http://www.gitorious.org/~bertram/mana/ ... ge-buttons

I need a review on the code before doing a merge to the mainline.

Thanks in advance for your help on this.

Best regards,